Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate and upload sha256 checksums #370

Merged
merged 4 commits into from
Feb 8, 2019
Merged

Generate and upload sha256 checksums #370

merged 4 commits into from
Feb 8, 2019

Conversation

Jake-Shadle
Copy link
Contributor

This PR attempts to add an additional "${artifact_name}.sha256" for each platform's release tarball that just contains the sha256 hash of that tarball. This would allow external packagers/installers (eg. scoop) to validate the tarballs without actually downloading the full tarball.

Resolves: #369

@Jake-Shadle
Copy link
Contributor Author

Oh, and though I am fairly sure the Travis config will work, I have much lower confidence in the Appveyor config as the docs around deployment stuff were...weird. Also I tried the powershell stuff in an online interpreter, but really have no idea what I am doing to be honest. Fake it till you make it!

@Jake-Shadle
Copy link
Contributor Author

Once this PR is merged, I can improve the scoop entry for sccache so that it can be easily kept up to date with new releases.

@luser
Copy link
Contributor

luser commented Feb 8, 2019

Oh, and though I am fairly sure the Travis config will work, I have much lower confidence in the Appveyor config as the docs around deployment stuff were...weird. Also I tried the powershell stuff in an online interpreter, but really have no idea what I am doing to be honest. Fake it till you make it!

This is my exact process for dealing with Travis and AppVeyor configs in general. I wish there were more sensible ways to test the release logic. 🤷‍♂️

@luser luser merged commit 1fa0c14 into mozilla:master Feb 8, 2019
@Jake-Shadle Jake-Shadle deleted the chksum branch February 11, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants