Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window release #373

Closed
wants to merge 1 commit into from
Closed

Fix window release #373

wants to merge 1 commit into from

Conversation

Jake-Shadle
Copy link
Contributor

@Jake-Shadle Jake-Shadle commented Feb 12, 2019

So I'm making my own releases on my fork for now, and I noticed only Windows was failing (when trying to use GCS), which turned out to be because only the default features (s3) were enabled. I thought this was weird because looking at appveyor, it should be using --features="all" at a minimum, but the actual executable in the tarball wasn't. It seems that the target/release/sccache.exe that was being tarballed was actually one that got overwritten by cargo test, not the one that was built initially with just cargo build. This was still super confusing, because...cargo test is supposedly using the same flags. I don't really know the root cause of this issue and am frankly tired of iterating on CI stuff, so I just did a quick fix to rerun the normal release build before doing the rest of the release deployment, which correctly enables all the features, and doesn't really add to much to build time because the intermediate rlibs are already all built and ready to go so it just needs to relink the executable.

¯\_(ツ)_/¯

@luser
Copy link
Contributor

luser commented Mar 7, 2019

I believe the root cause here is that we use escargo to run sccache via cargo run and it's not propagating the list of enabled features down. This comment seems to indicate that's the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants