Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -o flag separator type #376

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Fix -o flag separator type #376

merged 1 commit into from
Mar 7, 2019

Conversation

Jake-Shadle
Copy link
Contributor

When I tried to enable sccache for native compilation in addition to rust I ran into errors (the same kind as #189), I found that ring was causing sccache to fail because it's a bit more involved in the use of cc and when specifying the output object file is just directly concatenating the flag and the arg, so the command ends up being

$ "scccache" "gcc" blah blah blah "-c" "-o/somepathto.o" "somepathto.c"

Just changing the type of separator to support both -ofile or -o file allowed sccache to compile ring successfully.

Resolves: #189

@luser
Copy link
Contributor

luser commented Mar 7, 2019

Gosh, compiler options are weird, aren't they?

@luser luser merged commit 4271e43 into mozilla:master Mar 7, 2019
@Jake-Shadle Jake-Shadle deleted the out_fix branch August 21, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants