Add basic support for response files #378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 20, 2019 14:59
Credit to https://github.com/tmiasko/shell-words for the basic algorithm
|
I just realized Windows is completely broken because of |
|
@Jake-Shadle You may want to take a look at #192 for correct MSVC response file handling. Unfortunately, that PR never had much attention from the maintainers and was left to rot. Hopefully that doesn't happen here as well. |
|
Damn, I could have sworn I searched for issues/PRs related to this, but maybe I forgot. Will take a look when I can! |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the gcc and clang path will attempt to use response files (@) if there are no quotes inside the file, and the MSVC path will just bail immediately, this PR attempts to provide a best effort parsing of response files. I am fairly(ish) confident of the gcc/clang part, as I was able to compile the entirety of UE4, which uses response files almost exclusively, but I'm less confident of the MSVC one because...Windows gonna Windows.