fix(windows): remove DETACHED_PROCESS flag when starting the server process
#525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing per #514 (comment) |
|
Reopening per #514 (comment) |
glandium
force-pushed
the
no-detached-proccess
branch
from
b1411bf
to
7d68afa
Compare
… process See discussion in mozilla#514.
glandium
force-pushed
the
no-detached-proccess
branch
from
7d68afa
to
9a4479e
Compare
|
For good measure, I'll test this on Mozilla automation before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DETACHED_PROCESSflag causes theCREATE_NO_WINDOWto be ignored. See MS docs: https://docs.microsoft.com/en-us/windows/win32/procthread/process-creation-flags.I believe
DETACHED_PROCESSshould avoid creating a window (unless one callsAllocConsole), but we're definitely seeing these calls create console windows. I've observed that sccache 0.2.11 works fine and does not create console windows in command prompt, but creates many console windows in powershell. The result is that this PR is a bit of a hack fix (unless we can justify not actually needingDETACHED_PROCESS...?).Note: I'm planning on leaving the discussion at #514 (and off this PR, at least until some decision is made).