-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSRE-6] Upgrade Airflow (wtmo) to 2.1.1 #1377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haroldwoo
force-pushed
the
ta-2.1.1-upgrade
branch
from
October 13, 2021 01:06
cf7a5a0
to
8795036
Compare
jklukas
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc
Added suggestions for Variable
calls. Otherwise, changes here look good.
jasonthomas
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jasonthomas
reviewed
Oct 13, 2021
scholtzan
approved these changes
Oct 13, 2021
haroldwoo
force-pushed
the
ta-2.1.1-upgrade
branch
2 times, most recently
from
October 18, 2021 18:45
512283c
to
584daa5
Compare
haroldwoo
force-pushed
the
ta-2.1.1-upgrade
branch
from
October 18, 2021 18:54
590a9b0
to
35b6ebf
Compare
jklukas
added a commit
that referenced
this pull request
Oct 19, 2021
Since the airflow upgrade in #1377 these tasks are failing with: > ERROR: (gcloud.container.clusters.get-credentials) ResponseError: code=403, message=Required "container.clusters.get" permission(s) for "projects/moz-fx-data-shared-prod/zones/us-central1-a/clusters/bq-load-gke-1" These tasks should be writing to shared-prod, but accessing the GKE cluster using the default connection and project.
jklukas
added a commit
that referenced
this pull request
Oct 19, 2021
Since the airflow upgrade in #1377 these tasks are failing with: > ERROR: (gcloud.container.clusters.get-credentials) ResponseError: code=403, message=Required "container.clusters.get" permission(s) for "projects/moz-fx-data-shared-prod/zones/us-central1-a/clusters/bq-load-gke-1" These tasks should be writing to shared-prod, but accessing the GKE cluster using the default connection and project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #1334
I screwed the original PR up while trying to rebase/squash somehow so I'm recreating this pr
From: https://airflow.apache.org/announcements/
"May 21, 2021
I’m happy to announce that Apache Airflow 2.1.0 was just released. This one includes a raft of fixes and other small improvements, but some notable additions include:
Please note that this release no long includes the HTTP extra provider by default, as we discovered that it pulls in an LGPL dependency (via the requests module of all places) so it is now optional."
Cloud composer versions (just for reference)
https://cloud.google.com/composer/docs/concepts/versioning/composer-versions
More details DSRE-6
Commit messages (because these will eventually be squashed)
Except for our backported bigquery 1_10_2 code where new code also refs multiple conn ids.
The ltv dag references this backported code so is not changed.
Also this commit replaces GoogleCloudStorageDeleteOperator with the newer GCSDeleteObjectsOperator for 2.0
(in places I missed with a prev commit)