Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch kpi_forecast tasks in derived-datasets #1387

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Launch kpi_forecast tasks in derived-datasets #1387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions dags/utils/forecasting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
def simpleprophet_forecast(
task_id,
datasource,
project_id,
dataset_id,
table_id,
gcp_conn_id="google_cloud_derived_datasets",
project_id='moz-fx-data-derived-datasets',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring lists project_id as required, so removing default and changing position. In practice, all calls to this function are setting project_id already.

Note that for this function project_id refers to the destination table location rather than where the task is running.

gke_location="us-central1-a",
gke_cluster_name="bq-load-gke-1",
gke_namespace="default",
Expand Down Expand Up @@ -39,7 +39,6 @@ def simpleprophet_forecast(
return GKEPodOperator(
task_id=task_id,
gcp_conn_id=gcp_conn_id,
project_id=project_id,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to pass in project_id here, but rather use the default in GKEPodOperator

location=gke_location,
cluster_name=gke_cluster_name,
namespace=gke_namespace,
Expand Down