Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply hint: eta reduce breaks where block identation #94

Closed
jneira opened this issue Nov 13, 2020 · 2 comments · Fixed by #96
Closed

Apply hint: eta reduce breaks where block identation #94

jneira opened this issue Nov 13, 2020 · 2 comments · Fixed by #96
Labels

Comments

@jneira
Copy link
Contributor

jneira commented Nov 13, 2020

Hi, using hls-hlint-plugin an user has detected that apply "eta reduce" removes the identation of a where block, making the code throw parser errors

PS D:\dev\ws\haskell\cabal-test> cat .\src\HlintTests.hs
module HlintTests where

f  :: String -> String
f x = show x
  where y :: String
        y = "foo"

PS D:\dev\ws\haskell\cabal-test> hlint .\src\HlintTests.hs --refactor
module HlintTests where

f  :: String -> String
f = show
  where
y = "foo" y :: String

PS D:\dev\ws\haskell\cabal-test> hlint --version
HLint v3.2.1, (C) Neil Mitchell 2006-2020

PS D:\dev\ws\haskell\cabal-test> refactor --version
v0.8.2.1

Thanks in advance.

@zliu41
Copy link
Collaborator

zliu41 commented Nov 14, 2020

Thanks for reporting the bug! It's fixed in #96. If you'd like a release now please let me know; otherwise I'll make a release after closing #91, #93 and #95, hopefully in the next few days.

@jneira
Copy link
Contributor Author

jneira commented Nov 14, 2020

@zliu41 that was a really prompt response, many thanks
dont worry, i think we could wait to fix all to release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants