Add support for tagging EBS volumes #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good |
|
Awesome, thanks! BTW, hope you don't mind I've used ChatGPT for this, I basically gave it the EC2 instances tagging code and asked it to convert it to EBS volumes, and did this file by file. It converted the calls to EBS and worked like a charm with just a couple of manual fixes because some of the functions were named differently and had to be renamed to match. Once those were renamed the tests passed and it also worked when tested on my personal account against an existing volume. For ASGs I did all this manually and took me like 2-3h, but this was done in like 20min end to end |
|
No problem with ChatGPT at all :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.