Reduce flickering #132
Closed
Reduce flickering #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clearing of the screen introduced in 72239f0 made the screen flicker for users in tmux. Possibly because tmux might take longer time to draw than terminal emulators. Instead of clearing the whole screen before printing the choices and query, clear from the line below the last choice to the end of the screen before printing the query. This only can and needs to be done if the visible choices and the query do not completely fill the screen.
|
@mptre how does this look to you? |
|
This change breaks the output when not using the alternate screen and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clearing of the screen introduced in 72239f0 made the screen flicker
for users in tmux. Possibly because tmux might take longer time to draw
than terminal emulators.
Instead of clearing the whole screen before printing the choices and
query, clear from the line below the last choice to the end of the
screen before printing the query. This only can and needs to be done if
the visible choices and the query do not completely fill the screen.
This might resolve #131.