Remove usage of save and restore cursor #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of cursor save and restore capabilities is non-obvious. Moving the cursor the appropriate number of lines/columns is easier to follow. While at it, make the query cursor movement a single operation as opposed of the current implementation which is linear with the number of characters in the query.
|
Hey @mptre, sorry for the late feedback. The code looks great and I agree that it is easier to follow. Thanks for working on this! Pick runs without regressions on my machine. @teoljungberg Would you mind testing it in your tmux setup that had issues before? |
|
@calleerlandsson Looks good after testing this out locally. |
|
Thanks for testing, I'm merging now. While at it, time for another |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of cursor save and restore capabilities is non-obvious. Moving the
cursor the appropriate number of lines/columns is easier to follow.
While at it, make the query cursor movement a single operation as
opposed of the current implementation which is linear with the number of
characters in the query.
I would appreciate if others could test this change in order to not
introduce any regression.