Make make distcheck pass
#159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mptre
requested changes
Sep 18, 2016
| @@ -3,7 +3,7 @@ AC_INIT([pick], [1.4.0], [[email protected]]) | |||
| AM_INIT_AUTOMAKE([subdir-objects]) | |||
| AC_CONFIG_HEADERS([config.h]) | |||
| AC_PROG_CC | |||
| AC_CHECK_HEADERS([locale.h stdlib.h string.h unistd.h]) | |||
| AC_CHECK_HEADERS([limits.h locale.h stdlib.h string.h unistd.h]) | |||
There was a problem hiding this comment.
The sys/limits.h -> limits.h change makes sense and is more
portable. However, I would not bother adding the extra check since
limits.h is defined by POSIX[1].
[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html
There was a problem hiding this comment.
Great point! Fixed in 64a5107.
| @@ -3,6 +3,9 @@ | |||
| /* Define to 1 if you have the <inttypes.h> header file. */ | |||
| #undef HAVE_INTTYPES_H | |||
|
|
|||
| /* Define to 1 if you have the <limits.h> header file. */ | |||
|
Thanks for the feedback @mptre! I'll merge this. |
`<sys/limits.h>` isn't available on macOS.
`make distcheck` was failing on the `check` task during the VPATH build due to two reasons: 1. The `tests/*.t` and `tests/test.sh` were missing in the distribution. 2. The `T_LOG_COMPILER` command could not find the file `tests/test.sh` since it was located in the source directory, not the build directory.
calleluks
force-pushed
the
distcheck
branch
from
64a5107
to
b3c5bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for release, I ran
make distcheckand found it failing. With the changes in this PR it is passing.@mptre, I'd love your feedback on the changes and also if you could try running it on your system.