Refactoring and cleanup #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calleluks
approved these changes
Oct 4, 2016
There was a problem hiding this comment.
Looks great to merge! Thanks for working on this.
I'm going to make a patch release since the 1.5.0 Arch Linux build is broken due to the error fixed in 60fb41e: https://aur.archlinux.org/packages/pick/
| @@ -851,11 +848,11 @@ delete_between(char *string, size_t length, size_t start, size_t end) | |||
| int | |||
| isu8cont(unsigned char c) | |||
| { | |||
| return (c & (0x80 | 0x40)) == 0x80; | |||
| return MB_CUR_MAX > 1 && (c & (0x80 | 0x40)) == 0x80; | |||
There was a problem hiding this comment.
Nice, I didn't know about MB_CUR_MAX.
|
Thanks, you probably want to release prior merging this? |
|
Sure, I'll release tonight and then I'll merge this. |
- Remove space after tab - Make loop-condition explicit - Join conditionals
Removes the need to calculate the length twice.
Borrowed from OpenBSD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to
min_match,strcasechrand UTF-8 functions.