Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix underline spill over bug #174

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Fix underline spill over bug #174

merged 1 commit into from
Oct 28, 2016

Conversation

mptre
Copy link
Owner

@mptre mptre commented Oct 25, 2016

If the end of the match is greater than the number of columns the
underline attribute will spill over on the next line since it's never
exited. Running the following command before/after applying this commit
highlights the bug:

for _ in 0 1; do
  jot -n -s '' $(($COLUMNS - 1)) 0 0
  echo ab
done | pick -q ab

@calleluks
Copy link
Collaborator

Awesome! Thanks for finding that one. Confirmed as working on Debian 8. Merge at will.

If the end of the match is greater than the number of columns the
underline attribute will spill over on the next line since it's never
exited. Running the following command before/after applying this commit
highlights the bug:

  for _ in 0 1; do
    jot -n -s '' $(($COLUMNS - 1)) 0 0
    echo ab
  done | pick -q ab
@mptre mptre merged commit d914904 into master Oct 28, 2016
@mptre mptre deleted the underline branch October 28, 2016 09:15
@mptre
Copy link
Owner Author

mptre commented Oct 28, 2016

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants