Refactor get_key #189
Merged
Refactor get_key #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find this a easier to read and less error-prone due to usage of sizeof() instead of explicitly stating the length of the sequence.
Make sure to check the last read character prior reading a new one.
- Removes the need to validate the input buffer in get_choices() - Returning an enum gives us nice compiler warnings if a new key type where to be added
|
Hey @mptre, nice work! To me, the code reads better this way. Looks good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this diff laying around, finally took the time to split it up into several
commits. Thoughts and feedback are much appreciated.