Terminfo #197
Terminfo #197
Conversation
|
Tested and works flawlessly, so other KEY() macros could be replaced with CAP() too ... https://github.com/DBOTW/pick/commit/8dca7882391d9d9713d8c09c3fd7dcfc0e200f16 |
|
@DBOTW great! I would like to do a release before we migrate the rest of /cc @calleerlandsson |
pick.c
Outdated
| for (i = 0; keys[i].key != UNKNOWN; i++) { | ||
| if (keys[i].str == NULL) | ||
| keys[i].str = tty_getcap(keys[i].cap); | ||
| len = strlen(keys[i].str); |
There was a problem hiding this comment.
What do you think about caching this in keys like we do with the string?
| static struct { | ||
| enum key key; | ||
| const char *s; | ||
| size_t length; | ||
| char *cap; |
There was a problem hiding this comment.
I was wondering why this wasn't const char but then I saw tigetstr takes a char *. I'm not quite sure why though...
There was a problem hiding this comment.
Yeah, that's exactly why it can't be const. I don't have an
explanation either.
|
Great feedback! The length is now cached. |
A first step towards making pick truly portable. Defining a key using the new CAP() macro will read the corresponding value for the given capability using tigetstr(), the result will be stored in the keys structure in order to only invoke tigetstr() once per capability.
Also, overwrite any existing value for the mandatory environment variables. This is of important in order make the test environment consistent.
Read keys defined as terminal capabilities from terminfo
A first step towards making pick truly portable. Defining a key using
the new CAP() macro will read the corresponding value for the given
capability using tigetstr(), the result will be stored in the keys
structure in order to only invoke tigetstr() once per capability.
@DBOTW could you verify that this PR works as intended on your machine?