Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare handle_sigint as dead #210

Closed
wants to merge 1 commit into from
Closed

Declare handle_sigint as dead #210

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 9, 2017

Not really necessary, but usage is also declared as dead ...

@calleluks
Copy link
Collaborator

calleluks commented Jul 17, 2017 •
edited
Loading

This looks good to me! @mptre, do you have any thoughts on this?

@ghost
Copy link
Author

ghost commented Jul 17, 2017

Meanwhile I've changed my mind: it makes no difference in the resulting binary, because the compiler "sees" the exit-instruction. So better remove __dead from usage too and "help" the compiler only when warnings about this appear ...

@mptre
Copy link
Owner

mptre commented Jul 18, 2017

I think we should leave both handle_sigint and usage as is for now.
OK to close?

@ghost
Copy link
Author

ghost commented Jul 24, 2017

It's only about removing the __dead attribute from usage ... I think it confuses: why is usage marked as dead and handle_sigint not? Should be consistent in the source ...

@mptre
Copy link
Owner

mptre commented Jul 25, 2017

Lets keep it consistent, merged. Thanks!

@mptre mptre closed this Jul 25, 2017
@ghost ghost deleted the deadsig branch July 25, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calleluks @mptre