Explicitly handle control characters #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mptre
force-pushed
the
isig
branch
3 times, most recently
from
ed4f6e9
to
4817c62
Compare
|
Great work! I hope we will see |
|
Works great on macOS 10.12.6. Thanks for fixing this @mptre! Suspend/resume works like a charm now! |
The current SIGINT handler is not considered safe since it invokes functions that are not considered asynchronous safe[1]. Quoting the CERT C Coding Standard: In general, it is not safe to invoke I/O functions from within signal handlers. Instead, do not turn control characters into signal but instead handle the relevant ones explicitly. A pleasant side-effect is being able to test the Ctrl-C error path. While here, fix the broken suspend/resume behavior by resetting the initial terminal state prior suspending and re-read it upon resume. I do actually use suspend/resume while running pick when I forgot to check something that will affect the choice to select. [1] https://www.securecoding.cert.org/confluence/display/c/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers
teoljungberg
added a commit
to calleluks/pick.vim
that referenced
this pull request
Sep 20, 2017
In [pick#240] support was added to handle Ctrl-C, this commit fixes that behavior in the vim plugin to not crash with an error when that happens. [pick#240]: mptre/pick#240
|
I opened calleluks/pick.vim#21 to resolve this in pick.vim too. |
teoljungberg
added a commit
to calleluks/pick.vim
that referenced
this pull request
Sep 25, 2017
In [pick#240] support was added to handle Ctrl-C, this commit fixes that behavior in the vim plugin to not crash with an error when that happens. [pick#240]: mptre/pick#240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current SIGINT handler is not considered safe since it invokes
functions that are not considered asynchronous safe[1]. Quoting the
CERT C Coding Standard:
In general, it is not safe to invoke I/O functions from within signal
handlers.
Instead, do not turn control characters into signal but instead handle
the relevant ones explicitly. A pleasant side-effect is being able to
test the Ctrl-C error path.
While here, fix the broken suspend/resume behavior by resetting the
initial terminal state prior suspending and re-read it upon resume. I do
actually use suspend/resume while running pick when I forgot to check
something that will affect the choice to select.
[1] https://www.securecoding.cert.org/confluence/display/c/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers