Remove Werror compiler flag #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calleluks
reviewed
Jan 11, 2018
.travis.yml
Outdated
| - os: linux | ||
| compiler: clang-5.0 | ||
| env: BUILD_TYPE=default CFLAGS='-fsanitize=address -fsanitize=undefined' | ||
| env: BUILD_TYPE=default CFLAGS=' -fsanitize=address -fsanitize=undefined -Werror' |
There was a problem hiding this comment.
It seems like a space snuck in just before -fsanitize.
mptre
force-pushed
the
werror
branch
7 times, most recently
from
9526d17
to
0cb2f06
Compare
|
This was a new low on Travis: |
mptre
force-pushed
the
werror
branch
3 times, most recently
from
321436d
to
5ba9f37
Compare
|
This seems to be the cause travis-ci/travis-ci#9033. |
It's generally considered bad practice to ship software with this flag. Issue revealed while updating the port on OpenBSD[1]. [1] https://marc.info/?l=openbsd-ports&m=151482370923381&w=2
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
=======================================
Coverage 90.53% 90.53%
=======================================
Files 1 1
Lines 507 507
=======================================
Hits 459 459
Misses 48 48Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's generally considered bad practice to ship software with this flag.
Issue revealed while updating the port on OpenBSD.