-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: Improve Rendering Performance #26
Comments
Check #27 if this issue is necessary. |
Maybe using something like this helps: https://doc-snapshots.qt.io/qt6-6.5/qtquick-itemvariablerefreshrate-example.html |
Asked for help in the Qt forum: https://forum.qt.io/topic/149728/improve-rendering-performance-while-integrating-libmpv-with-qtquick-python |
* Implement key event handler * Implement key event listener * Implement e key press * Add command generator stub * Call command generator * Add more special mappings * Implement command generator * Refactor minor things * Refactor minor things * Restructure key event processing * Execute custom player commands * Make ignore keys more explicit * Make return key edit comments
Hi @trin94 I've tested this with 24fps and 5fps videos but the UI seems unaffected? I don't notice any lag or slowdowns when interacting with the UI. Tested on linux. Edit: nvm you're right |
This rendering issue only applies for Linux on both x11 and Wayland. On Windows, we now (f6e7cde) do hWnd embedding instead of libmpv rendering. Unless someone has a clever idea, I don't think we can do much about it until there's a Wayland protocol including common compositor support for this. |
For Linux users, a temporary fix is to adjust the video-timing-offset setting in mpv ( By default, video-timing-offset is set to Here are suggested values for different frame rates:
Note: This requires powerful hardware, and even with adjustments, you might still see frame drops or audio sync issues. You can check for any audio-video drift in mpvQC by pressing |
The rendering performance issue is caused by us rendering into the same framebuffer as Qt renders its UI. When playing 24 fps videos, this reduces the framerate being rendered to 24 fps. And therefore menu animations and GUI interactions result in a bad user experience.
We tried playing around with mpv not blocking for the next frame but that leads to frame drops mpvqc/mpvQC-dev#61.
We need to find a different way to improve performance.
Ideas:
The text was updated successfully, but these errors were encountered: