Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some properties can be multiple #60

Merged
merged 2 commits into from
Jul 6, 2019
Merged

Some properties can be multiple #60

merged 2 commits into from
Jul 6, 2019

Conversation

scarry1992
Copy link
Contributor

@scarry1992
Copy link
Contributor Author

@mcollina, review pls and release in npm with path version.

mcollina
mcollina requested changes Jun 29, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
Would you mind updating the docs?

@scarry1992
Copy link
Contributor Author

@mcollina, I added new info in docs. Check pls.

@scarry1992 scarry1992 requested a review from mcollina July 1, 2019 07:07
mcollina
mcollina approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit b9cb532 into master Jul 6, 2019
@mcollina mcollina deleted the multiple-properties-mqtt-5 branch July 6, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scarry1992 @mcollina