Move wait() into Navigation #51
Comments
mrWh1te
added a commit
that referenced
this issue
Aug 25, 2020
- moved sleep() into helpers/navigation - deleted helpers/utilties - consolidated tests (tests related were moved into */navigation.spec.ts) - Resolve issue #51
mrWh1te
added a commit
that referenced
this issue
Aug 27, 2020
* Moved wait() into Navigation - moved sleep() into helpers/navigation - deleted helpers/utilties - consolidated tests (tests related were moved into */navigation.spec.ts) - Resolve issue #51 * Compose screenshotAll() BotAction - Resolves issue #50 * LinkedIn ConditionalBotAction isGuest & isLoggedIn - issue #55 * postIsAuthoredByAPerson - potential concept, with notes on using fuzzy string matching to make function more resilient to change ie middle-initials, nicknames, etc * LinkedIn like() and enhanced getFeedPosts - like uses errors()() in case the selector doesn't find anything, the promise of page.click() will reject - now getFeedPosts() with default function to filter Promoted content from returned scraped posts, unless overridenn - issue #55 * like() does not toggle - like() clicks Like button of Post if button not pressed, since it will error with wrong selector given an attribute value is different when pressed or not * LinkedIn Navigation BotAction's & Like enhance - like() does not toggle, because part of the selector attribute value changes based on selected status, so it will error if liked already - error is caught - navigation botaction's with configuration to help navigate the web app * Clean Up likeAllFrom() - no need for array, cleaner syntax * Feed polish - linkedin example needs fleshing out to verify the functionality * Code Quality - from master lgtm review * LinkedIn Example - fleshed out login flow with working session restoration via cookies - fixed a selector bug with grabbing posts (was grabbing articles within posts too for post content that is comment of someone you follow) - resolved bug in $$ BotAction where a pipe object was being used as the injected parser * Fixed Tests - added a test case for using toString() on an object and when an object does not have it * LinkedIn Selectors - reusable selectors separated out - going to leave likeAllFrom() since it needs additional work not originally scoped of handle various Feed Posts' types - might schedule that work for once switchPipe()() and case()() are complete * CHANGELOG - starting at v2.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In some ways, it's kind of like Navigation, ie reload() without reloading... and similar language to
waitForNavigationwhile helping Utility BotAction's focus on logical branching/loopingNo fundamental changes to API, just change of BotAction category/type for
wait()can be included with a future release
The text was updated successfully, but these errors were encountered: