-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restart() BotAction #97
Conversation
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 665 685 +20
Branches 169 172 +3
=========================================
+ Hits 665 685 +20
Continue to review full report at Codecov.
|
- this allows you to build a bot script that varies on each attempt, like your not sure exactly how the bot will accomplish X, but you have an idea and need to do trial and error with slight differences on each try by adjusting the pipe value of the first assembled BotAction to the value resolved from the optional useThisActionsPipeValueOnRecycle
going to simplify recycle's design use abort(1, 'pipe-value') as a means to setup the next pipe value for the next iteration of scheduled actions therefore there is no need for an additional optional param, type BotAction, because both the |
should the initial pipe value, received by schedule, be reused for each scheduled line of BotActions or should the last value returned by the last assembled BotAction, of each schedule, be used as the pipe value for the next assembled lines of BotActions final returned value is passed through |
what if the final return value was a signal like Cases Signal that was a summary/report of dates when actions ran with their end result pipe value? edit: schedule()() could work like this ie edit2: this would be a edit3: is it worth differentiating signals with a new group called reports? Signals directly cause an effect. A report is data to be ingested that may (or may not) indirectly cause an effect. |
fixed a bug for a rare edge-case with the edit: essentially if a unit-test has been added to cover this now and in the future |
- the rare edge case of using processAbortLineSignal with a reduction in assembledLines count > 1 is rare with an edge case of assembledLines and reduction number being the same, returning an Infinity signal instead of the signals pipe value
might adjust schedule()'s return to a more informative signal in the future, but for recycle(), kept it more in line with what pipe does, returns the final action value, with the small addition that a default botmation's architecture is summarized by Einstein's quote - as simple as possible but no simpler. Each BotAction should do one one thing only, very well. This prevents technical debt, in the form of functional entanglement that increases the cost of adding/removing/modifying flows of functionality that scales exponentially with complexity. That is, the more complex the features, the more complex the changes, the more exponential the rise in cost of adding/removing functionality due to technical debt in the form of functional entanglement it's like trying to surgically replace a meatball in a plate of spaghetti with a sausage. The sausage has to be precisely placed, after carefully removing the meatball and then all those threads of spaghetti that pertain to this sausage, once connected to the meatball, have to be reconnected to the sausage, in various places. The more out of control that spaghetti is, the less consolidated it is, the less organized, the more expensive it drastically becomes to do this |
rename |
should |
Puppeteer v8 and |
- wip -> instagram package not installing?
- the <2.0.0 didnt work, im surprised - changed back to ^1.x which should be fine since the Minor number is greater than zero, which is what caused the original problem of syncing deps
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
published:
also new docs published |
Description
Recycle abort line signals to restart an assembled line of BotActions
Related
Checklist
RecycleRestartassembledLines
optionally set minimumassembledLines
Documentation
Publishing