-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 PnL code structure alignement #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mraniki - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Methods: | ||
get_quote(self, instrument) | ||
get_offer(self, instrument) | ||
get_bid(self, instrument) | ||
get_account_balance(self) | ||
get_account_position(self) | ||
calculate_pnl(self, period=None) | ||
get_account_pnl(self, start_date) | ||
execute_order(self, order_params) | ||
get_trading_asset_balance(self) | ||
get_order_amount(self, quantity, instrument, is_percentage) | ||
pre_order_checks(self, order_params) | ||
replace_instrument(self, instrument) | ||
get_instrument_decimals(self, instrument) | ||
get_trade_confirmation(self, order_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code_clarification): Consider documenting method purposes in the class docstring.
While listing methods in the class docstring provides an overview, including a brief description of each method's purpose or functionality could enhance readability and maintainability.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 71.19% 70.99% -0.20%
==========================================
Files 7 7
Lines 427 431 +4
==========================================
+ Hits 304 306 +2
- Misses 123 125 +2 ☔ View full report in Codecov by Sentry. |
No description provided.