⬆️🐛 #446
Merged
⬆️🐛 #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @mraniki - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -248,7 +248,8 @@ async def get_instrument_decimals(self, instrument): | |||
| async def get_instrument_min_amount(self, instrument): | |||
| """ """ | |||
| instrument_info = self.client.single_market(instrument) | |||
| minimum_amount = instrument_info.get("minDealSize", {}).get("value", 0) | |||
| logger.debug("instrument_info {}", instrument_info) | |||
There was a problem hiding this comment.
suggestion (code_refinement): Consider adding more descriptive logging for instrument_info.
Including specific fields of interest in the log could help in debugging specific issues more effectively.
Suggested change
| logger.debug("instrument_info {}", instrument_info) | |
| logger.debug("instrument_info: dealingRules: {}", instrument_info.get("dealingRules")) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 71.46% 71.52% +0.06%
==========================================
Files 7 7
Lines 438 439 +1
==========================================
+ Hits 313 314 +1
Misses 125 125 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.