✨ feature calculate_pnl via rotki

[mraniki]

No description provided.

[sourcery-ai]

Hey @mraniki - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

• Hard-coded endpoint URL should be avoided in configuration files. (link)
• Hard-coded endpoint URL should be avoided, even in commented code. (link)
• Avoid including hard-coded URLs in the codebase. (link)
• Hard-coded URLs in configuration files are a security risk. (link)
• Hard-coded URLs should be replaced with configurable options. (link)

Here's what I looked at during the review

• 🟡 General issues: 3 issues found
• 🔴 Security: 5 blocking issues
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Docstrings: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion (code_clarification): Consider raising an exception or logging when 'rotki_report_endpoint' is None.

Returning 0 might mask the issue that 'rotki_report_endpoint' is not set, which could lead to harder-to-debug problems later. Raising an exception or at least logging a warning could provide clearer feedback on the configuration issue.

Suggested change

	if self.rotki_report_endpoint is None:
	return 0
	if self.rotki_report_endpoint is None:
	raise ValueError("rotki_report_endpoint is not set.")

[sourcery-ai]

suggestion (code_refinement): Consider handling different HTTP status codes with specific actions or logs.

Different non-200 status codes can indicate various issues (e.g., 404 not found, 500 server error). Handling these explicitly could improve debugging and user feedback.

Suggested change

	if response.status != 200:
	logger.error(f"Received non-200 status code: {response.status}")
	return 0
	if response.status == 404:
	logger.error("Resource not found: 404 error")
	elif response.status == 500:
	logger.error("Server error: 500 error")
	else:
	logger.error(f"Unexpected status code received: {response.status}")
	return 0

[sourcery-ai]

suggestion (edge_case_not_handled): Validate 'free' field presence before conversion to float.

Directly converting the 'free' field to float without checking its presence might lead to unexpected errors if the field is missing. Consider validating its presence first.

Suggested change

	try:
	free_amount = float(amounts.get("free", "0"))
	free_amount_str = amounts.get("free")
	if free_amount_str is not None:
	free_amount = float(free_amount_str)
	else:
	free_amount = 0.0

[sourcery-ai]

🚨 issue (security): Hard-coded endpoint URL should be avoided in configuration files.

Consider using environment variables or configuration management systems to handle sensitive or environment-specific data securely.

[sourcery-ai]

🚨 issue (security): Hard-coded endpoint URL should be avoided, even in commented code.

This can lead to accidental exposure of endpoints when uncommenting or refactoring code. Use more secure methods to manage such data.

[sourcery-ai]

🚨 issue (security): Avoid including hard-coded URLs in the codebase.

Even if commented out, these can be mistakenly used or exposed. Use configuration management for such values.

[sourcery-ai]

🚨 issue (security): Hard-coded URLs in configuration files are a security risk.

It's recommended to use environment-specific configuration files or environment variables to manage such data.

[sourcery-ai]

🚨 issue (security): Hard-coded URLs should be replaced with configurable options.

This helps in maintaining security and flexibility across different environments.

[codecov]

Codecov Report

Attention: Patch coverage is 8.69565% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 77.47%. Comparing base (1cb75de) to head (4cdff25).

Files	Patch %	Lines
dxsp/handler/client.py	8.69%	21 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   80.16%   77.47%   -2.70%     
==========================================
  Files          11       11              
  Lines         595      617      +22     
==========================================
+ Hits          477      478       +1     
- Misses        118      139      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.