fix arraymancer for https://github.com/nim-lang/Nim/pull/18050 #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mratsim can you please tag a new release? otherwise the packages that depend on this won't see this change (and would still fail) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unblocks nim-lang/Nim#18050 which fixes the long-standing generic sandwich problem in nim (nim CI in that nim PR fails for 2 packages which depend on arraymancer; this arraymancer PR fixes it)
this is forward and backward compatible.
I can change the PR to
from ../../tensor/data_structure import sizeabove copyFromRaw if needed (either works)size isn't defined in this the scope where
copyFromRawuses it, and only works currently in nim devel because of the generic sandwich problem; but after nim-lang/Nim#18050 it won't work unless either mixin is used orfrom ../../tensor/data_structure import sizeis used.