Allow bom markers #168
Merged
Allow bom markers #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 140 140
Lines 3131 3131
Branches 436 436
=======================================
Hits 3130 3130
Misses 1 1 ☔ View full report in Codecov by Sentry. |
EmmaLRussell
approved these changes
Aug 10, 2023
| @@ -6,6 +6,12 @@ describe("configReader", () => { | |||
| jest.resetAllMocks(); | |||
| }); | |||
|
|
|||
| it("copes with BOM markers", () => { | |||
| // This test needs to go before the mocks below | |||
There was a problem hiding this comment.
If you change line 6 to jest.restoreAllMocks();. this should no longer be the case!
There was a problem hiding this comment.
thanks, that does the trick!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a fight here. There is a package that does this (https://www.npmjs.com/package/strip-bom) but pulling that in requires changing the tsconfig to allow module interop and that breaks some mocks. The code is very simple though so I pulled it in. See nodejs/node-v0.x-archive#1918 for an issue where others have struggled with the underlying issue.
Deployed at https://wodin-dev.dide.ic.ac.uk/infectiousdiseasemodels-2023/apps/ebola/ where it works ok