Skip to content

Commit

Permalink
ui fix: filter bar placeholders should be useful based on the connection
Browse files Browse the repository at this point in the history
  • Loading branch information
mrdjohnson committed Jun 17, 2024
1 parent 31b30b8 commit 5d6cc9e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
7 changes: 5 additions & 2 deletions src/features/settings/panels/model/A1111ModelPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ const A1111ModelPanel = observer(({ connection }: { connection: A1111ServerConne
connectionModelStore.dataStore.setSelectedModel(model, connection.id)
}
itemFilter={(model, filterText) => {
return model.modelName.toLowerCase().includes(filterText.toLowerCase())
return (
model.modelName.toLowerCase().includes(filterText.toLowerCase()) ||
model.label.toLowerCase().includes(filterText.toLowerCase())
)
}}
primarySortTypeLabel={connection.primaryHeader}
renderRow={renderRow}
Expand All @@ -38,7 +41,7 @@ const A1111ModelPanel = observer(({ connection }: { connection: A1111ServerConne
model.modelName === connectionModelStore.selectedModelName
}
getItemKey={model => model.id}
filterInputPlaceholder="Filter by name or folder..."
filterInputPlaceholder="Filter by title or name..."
/>
)
})
Expand Down
7 changes: 5 additions & 2 deletions src/features/settings/panels/model/OpenAiModelPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ const OpenAiModelPanel = observer(({ connection }: { connection: OpenAiServerCon
connectionModelStore.dataStore.setSelectedModel(model, connection.id)
}
itemFilter={(model, filterText) => {
return model.modelName.toLowerCase().includes(filterText.toLowerCase())
return (
model.modelName.toLowerCase().includes(filterText.toLowerCase()) ||
model.ownedBy.toLowerCase().includes(filterText.toLowerCase())
)
}}
primarySortTypeLabel={connection.primaryHeader}
renderRow={renderRow}
Expand All @@ -47,7 +50,7 @@ const OpenAiModelPanel = observer(({ connection }: { connection: OpenAiServerCon
model.modelName === connectionModelStore.selectedModelName
}
getItemKey={model => model.id}
filterInputPlaceholder="Filter by name or folder..."
filterInputPlaceholder="Filter by id or owned by..."
/>
)
})
Expand Down

0 comments on commit 5d6cc9e

Please sign in to comment.