Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SphericalHarmonicsLight. #13115

Closed
wants to merge 13 commits into from
Closed

Added SphericalHarmonicsLight. #13115

wants to merge 13 commits into from

Commits on Jan 15, 2018

  1. Added SphericalHarmonicsLight. An ambient lighting term based on 3rd … 

    …order spherical harmonics.
    Andreas Atteneder committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    2db588d View commit details
    Browse the repository at this point in the history

  2. Fix: Removed "Values" suffix from variable names (as suggested).

    Andreas Atteneder committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    4b4eaad View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2018

  1. Removed unused shader from example.

    Andreas Atteneder committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    0fae2c8 View commit details
    Browse the repository at this point in the history

  2. Manually merged/copied previous work on spherical harmonics by Ben Ho… 

    …uston found here: bhouston@07ee8b1

Changes: Utilize SphericalHarmonics3 class to create a SphericalHarmonicsLight (instead of plain coefficient values).
Using Ben's shader functions from spherical_harmonics_in.glsl and removed my previous implementation.
Note: Moved demo values from original SphericalHarmonics3 class into example webgl_lights_spherical_harmonics.html. I thought they don't need to be in the build.
    Andreas Atteneder committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    4d868da View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2018

  1. Feature: Scale impact of SphericalHarmonicsLight with an intensity fa… 

    …ctor.
    Andreas Atteneder committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    6606a8b View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2018

  1. Minor fixes from PR feedback 

    - Renamed variable
- Implemented SphericalHarmonics3.toArray()
mrdoob#13115
    Andreas Atteneder committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    4ca75d7 View commit details
    Browse the repository at this point in the history

  2. Removed redundant worldNormal in favour of GeometricContext. 

    mrdoob#13115 (review)
    Andreas Atteneder committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    7201105 View commit details
    Browse the repository at this point in the history

  3. ES5 compatibility ( fixes build-uglify )

    Andreas Atteneder committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    4fc8dc3 View commit details
    Browse the repository at this point in the history

  4. Removed LinearToGamma conversion from spherical harmonics term. Value… 

    … should already be in linear space.
    Andreas Atteneder committed Jan 29, 2018
    2 Configuration menu
    Copy the full SHA
    2300368 View commit details
    Browse the repository at this point in the history

  5. Fix: removed redundant irradiance term ( spherical harmonics and envi… 

    …ronment map at mip map level 8 being added ). New behaviour: if a SphericalHarmonicsLight is present, it is used. Otherwise we fall back to then environment map.
    Andreas Atteneder committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    aa88a65 View commit details
    Browse the repository at this point in the history

  6. Encapsulated accessor function shGetIrradianceAt in intermediate func… 

    …tion getSHLightProbeIndirectIrradiance.

As suggested by bhouston mrdoob#13115 (comment)
    Andreas Atteneder committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    586d372 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2018

  1. Changed SphericalHarmonics3 coefficients to be Vector3 (instead of Co… 

    …lors), following this discussion: mrdoob#13115 (comment)
    Andreas Atteneder committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    e51f738 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2018

  1. Merge branch 'dev' into feature/spherical_harmonics_ambient 

    # Conflicts:
#	src/renderers/shaders/ShaderChunk/lights_fragment_begin.glsl
#	src/renderers/shaders/ShaderChunk/lights_pars_maps.glsl
    Andreas Atteneder committed Mar 24, 2018
    Configuration menu
    Copy the full SHA
    719ea0f View commit details
    Browse the repository at this point in the history