NodeMaterial: Bias example #17190
Merged
NodeMaterial: Bias example #17190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my conclusion, I not see reasons for not use this feature. |
|
only for test and obtain a clean result I put a PREM in PhongNodeMaterial 😅 |
|
The blur based on the intermediate curve of bias seems different for both. Only to ensure I will to do more tests related to PBM |
This not affect this test. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17163 (comment)
@WestLangley This is the experiment, note that for
irradiancethe default value is 1 in bias, for me inirradiancethe result is good for both. Without LOD if compared with BASIC is bad inradiancebecause it needs intermediate values (0-1).https://rawgit.com/sunag/three.js/dev-nodes-irradiance/examples/webgl_materials_nodes.html?e=bias