Shaders: decouple light probe irradiance from other indirect light sources #17359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunag
reviewed
Aug 27, 2019
| @@ -15,9 +15,11 @@ export default /* glsl */` | |||
|
|
|||
| #endif | |||
|
|
|||
| vec3 iblIrradiance = vec3( 0.0 ); | |||
There was a problem hiding this comment.
You can move this to lights_fragment_begin.glsl.js maybe here?
Probably this breaks compatibility with
NodeMaterial.
There was a problem hiding this comment.
I think you will have to decide where it is best to declare it. I do not understand the Node restrictions very well...
There was a problem hiding this comment.
I think that bellow of irradiance is better
vec3 irradiance
vec3 iblIrradianceNo ..._maps chunk is added in node-material
There was a problem hiding this comment.
@sunag I'll merge and do that change 👌
|
Thanks! |
|
@WestLangley Thanks! |
|
@WestLangley Is not necessary create an |
|
You could, but this was the minimal change. The entire shader probably needs to be rewritten at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17253.
As suggested in #17102 (comment) and #17253 (comment).
This also fixes an unreported bug. The multi-scattering, energy-preservation model introduced in #15644 should only have been applied to irradiance from IBLs, but it was applied to all indirect diffuse light sources.
/ping @jsantell
/ping @elalish
/ping @sunag
/ping @bhouston