Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMDLoader: Apply color management to textures. #26554

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

donmccurdy
Copy link
Collaborator

@mrdoob mrdoob added this to the r156 milestone Aug 8, 2023
Copy link
Collaborator

@takahirox takahirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, yes we are missing color space assignment on color textures in MMD loader.

@takahirox
Copy link
Collaborator

takahirox commented Aug 8, 2023

I tested locally with a PMX file. Using SRGB color space looks fine.

Reference: https://www.nicovideo.jp/watch/sm18003162

image

before after (SRGB) LinearSRGB
image image image

@Mugen87 Mugen87 merged commit 5c638c4 into mrdoob:dev Aug 9, 2023
17 checks passed
@donmccurdy donmccurdy deleted the hotfix/mmd-colormanagement-textures branch August 9, 2023 11:02
@jasondalycan
Copy link

jasondalycan commented Aug 12, 2023

Thanks guys. It looks better (more color now) but it still looks a bit light compared to the rendering in r92. Not sure if this is the intention? See the following:

r92:
image

After this commit (26554):
image

@donmccurdy
Copy link
Collaborator Author

@jasondalycan the renderings above appear similar enough to me that they may be caused only by lighting and not color management. Some adjustments to lighting are to be expected, given changes in the past few releases. Adjustment to renderer.toneMapping or renderer.toneMappingExposure may be worth trying as well, but less likely in this case.

If there does seem to be a remaining color management issue, I think we would need an example (model) to investigate it.

@jasondalycan
Copy link

Ok thanks I'll work with adjusting lighting settings and report back if any additional findings. cheers

@danpaldev
Copy link

danpaldev commented May 11, 2024

Ok thanks I'll work with adjusting lighting settings and report back if any additional findings. cheers

By any chance did you find a fix for this? Almost a year later I keep observing the washed out colors, even with lighting on/off.

Threejs
image

Other renderer:
image

@Mugen87
Copy link
Collaborator

Mugen87 commented May 11, 2024

see #28336 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MMDLoader Colorization Issue
6 participants