TSL: Add function for BPCEM. #29773
Merged
TSL: Add function for BPCEM. #29773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
changed the title
Mugen87
changed the title
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
Wow! It's so easy to use now. |
|
/fyi @spite @sneha-belkhale |
WestLangley
reviewed
Nov 1, 2024
| @@ -354,6 +354,7 @@ | |||
| "webgpu_materials_arrays", | |||
| "webgpu_materials_basic", | |||
| "webgpu_materials_displacementmap", | |||
| "webgpu_materials_envmaps_bpcem", | |||
There was a problem hiding this comment.
How about a different name, for clarity?
webgpu_materials_envmaps_box_projectedSimilar to
webgl_materials_envmaps_ground_projected(The latter is currently missing an underscore.)
There was a problem hiding this comment.
webgl_materials_envmaps_ground_projected
I think this should be webgl_skybox_ground_projected. This example is not related to the envMap material property.
Regarding the new example, I don't feel strong about the name. BPCEM is a similar term like PMREM which is why I like and picked it.
There was a problem hiding this comment.
Whatever you prefer is OK with me... I thought the acronym may be unfamiliar.
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #15897
Description
This PR introduces a helper function for using box projected cube environment mapping (BPCEM) for cube textures and PMREMs. This is a nice feature when using environment maps in indoor scenes.
See https://devlog-martinsh.blogspot.com/2011/09/box-projected-cube-environment-mapping.html.
We had this feature in the repository in earlier days as an example but eventually removed it since the shader patching approach was error-prone and broke the demo more than once. Now with TSL we can implement this feature in a much more elegant fashion. There is now the TSL function
getParallaxCorrectNormal()which can be used to compute custom uvs when usingcubeTexture()orpmremTexture().