NodeMaterial - PR

[sunag]

#7522

[mrdoob]

Looking good!

Are you still planning on changing THREE.Node* to THREE.*Node (except THREE.NodeMaterial)?

[sunag]

Yes! I was going to ask you about it. You has a list of names or I can change all except NodeMaterial?

Currently this is the names

<!-- NodeMaterial Base -->
<script src="js/materials/nodes/NodeGL.js"></script>
<script src="js/materials/nodes/NodeBuilder.js"></script>
<script src="js/materials/nodes/NodeRaw.js"></script>
<script src="js/materials/nodes/NodeTemp.js"></script>
<script src="js/materials/nodes/NodeInput.js"></script>
<script src="js/materials/nodes/NodeMaterial.js"></script>
<script src="js/materials/nodes/NodeConst.js"></script>
<script src="js/materials/nodes/NodeFunction.js"></script>
<script src="js/materials/nodes/NodeFunctionCall.js"></script>
<script src="js/materials/nodes/NodeLib.js"></script>

<!-- Accessors -->
<script src="js/materials/nodes/accessors/NodeColors.js"></script>
<script src="js/materials/nodes/accessors/NodeCamera.js"></script>
<script src="js/materials/nodes/accessors/NodeNormal.js"></script>
<script src="js/materials/nodes/accessors/NodePosition.js"></script>
<script src="js/materials/nodes/accessors/NodeReflect.js"></script>
<script src="js/materials/nodes/accessors/NodeUV.js"></script>

<!-- Inputs -->
<script src="js/materials/nodes/inputs/NodeColor.js"></script>
<script src="js/materials/nodes/inputs/NodeFloat.js"></script>
<script src="js/materials/nodes/inputs/NodeInt.js"></script>
<script src="js/materials/nodes/inputs/NodeVector2.js"></script>
<script src="js/materials/nodes/inputs/NodeVector3.js"></script>
<script src="js/materials/nodes/inputs/NodeVector4.js"></script>
<script src="js/materials/nodes/inputs/NodeTexture.js"></script>
<script src="js/materials/nodes/inputs/NodeCubeTexture.js"></script>

<!-- Math -->
<script src="js/materials/nodes/math/NodeMath1.js"></script>
<script src="js/materials/nodes/math/NodeMath2.js"></script>
<script src="js/materials/nodes/math/NodeMath3.js"></script>
<script src="js/materials/nodes/math/NodeOperator.js"></script>

<!-- Utils -->
<script src="js/materials/nodes/utils/NodeJoin.js"></script>
<script src="js/materials/nodes/utils/NodeSwitch.js"></script>
<script src="js/materials/nodes/utils/NodeTime.js"></script>
<script src="js/materials/nodes/utils/NodeRoughnessToBlinnExponent.js"></script>

<!-- Interfaces -->
<script src="js/materials/nodes/interfaces/NodePhong.js"></script>
<script src="js/materials/nodes/interfaces/NodePhongMaterial.js"></script>
<script src="js/materials/nodes/interfaces/NodeStandard.js"></script>
<script src="js/materials/nodes/interfaces/NodeStandardMaterial.js"></script>

<!-- Extras -->
<script src="js/materials/nodes/extras/NodeVelocity.js"></script>

[mrdoob]

Yeah, I think I would name THREE.*Node all the classes that are meant to be used in the graph.

[sunag]

I will do this with a regular expression /(Node)(\w+)/g to $2$1 . Let's see if it works : )

[sunag]

What do you think of leaving MaterialNode to be all standardized?

** https://github.com/sunag/three.js/blob/1558f02a70cfaa55973457685df56ee4fdeb41f8/examples/js/materials/nodes/MaterialNode.js

[mrdoob]

Hmm, NodeMaterial is a type of Material so I think it should end with Material.

[sunag]

Understand. In this same thought I will have to change these two that are extended materials:

https://github.com/sunag/three.js/blob/1558f02a70cfaa55973457685df56ee4fdeb41f8/examples/js/materials/nodes/interfaces/PhongMaterialNode.js

https://github.com/sunag/three.js/blob/1558f02a70cfaa55973457685df56ee4fdeb41f8/examples/js/materials/nodes/interfaces/StandardMaterialNode.js

to PhongNodeMaterial.js and StandardNodeMaterial.js

[mrdoob]

That makes sense to me 👍

[sunag]

Missed MrDoob approves

[mrdoob]

Hold on a second. PhongNodeMaterial/PhongMaterialNode is a type of Node? Then it should be PhongMaterialNode yes.

[sunag]

PhongNodeMaterial/PhongMaterialNode is a type of Node?

Hmm, PhongNode.js is a type of Node, PhongNodeMaterial is a type of Material.

PhongNode instanceof THREE.GLNode
https://github.com/sunag/three.js/blob/1558f02a70cfaa55973457685df56ee4fdeb41f8/examples/js/materials/nodes/interfaces/PhongNode.js#L7

PhongNodeMaterial instanceof THREE.NodeMaterial
https://github.com/sunag/three.js/blob/1599e1ac2e32bd738615e72b1ba8221df83b2dc9/examples/materials/nodes/interfaces/NodePhongMaterial.js#L9

I am using a proxy to facilitate the use of NodeMaterial in intermediate materials.

[mrdoob]

Ah ok. PhongNodeMaterial is good then 😁

[mrdoob]

Thanks!

[bhouston]

Sweet! Thank you! I'll have a look at this next week.