Relationships are not commited, but return no error

[pavlot]

This commented out code makes that relationships are not commited

flask-restless-ng/flask_restless/views/relationships.py

Line 178 in 3edf5de

# TODO do we need to commit the session here?

I suspect idea was done to allow postprocessors can rollback changes, but now it makes that relationship is not saved.

Also I think that tests should be improved to check not only return status, but try to reload relationship and check whether it exists. Now code return HTTP-204, but it do nothing

[mrevutskyi]

hi @pavlot,
thank you for the report. Sorry, haven't noticed it earlier.

Do you have a scenario I can reproduce the issue? Or what specific test you are referring to?
tests in test_updating_relationships.py do check db changes.
E.g.

assert response.status_code == 204 articles = sorted(person.articles, key=attrgetter('id')) assert [article1, article2] == articles

[mrevutskyi]

Closing the issue as I'm not able to reproduce, please reopen if you are still facing it