Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync matched text, instead of original text, to other clipboard #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sync matched text, instead of original text, to other clipboard #87

wants to merge 1 commit into from

Conversation

rayx
Copy link

@rayx rayx commented Oct 17, 2019

Fix #86

@rayx
Sync matched text, instead of original text, to other clipboard
c628370 
The change fixes an indefinite loop issue between primary selection
and clipboard synchronization, which can be reproduced with the following
config:

    active_selections = PRIMARY,CLIPBOARD
    sync_selections = yes
    extract_patterns = yes
    pattern_as_selection = yes

Defining a pattern to extract part of the selected text should reprodcue
the issue.
@mrichar1
Copy link
Owner

Thanks for reporting this issue.

I've managed to replicate it, though I notice that your PR has an unexpected effect on the test_sync_selections test.

It appears that this fix is changing the behaviour of the code when pattern_as_selection is disabled - though I've not had a chance to review the code to see what's causing this.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot closed this Apr 27, 2022
@mrichar1 mrichar1 reopened this Apr 28, 2022
@stale stale bot removed the stale label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sync_selections + pattern_as_selection = infinite loop
2 participants
@rayx @mrichar1