fix: let 'set' command fail on key not found #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanx, I do prefer the exit(1) variant, because the user don't need the Python traceback. |
Whenever a key is not found within a 'set' command, the command should error out instead of trying to continue execution and assign the value to a partially parsed key. This way no unintended modifications to the TOML file are performed. Example: `toml set --toml-path pyproject.toml tool.ruffs.target-version py39` The table `tool.ruffs` does not exist but the current implementation captures this exception and continues along, actually executing `tool.target-version = "py39"`.
limaa
force-pushed
the
fix/set-key-failure
branch
from
2ff6c91
to
c801f7c
Compare
|
I have updated to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a key is not found within a 'set' command. The command should error out instead of trying to continue execution and assign the value to a partially parsed key.
Example:
toml set --toml-path pyproject.toml tool.ruffs.target-version py39The table
tool.ruffsdoes not exist but the current implementation captures this exception and continues along, actually executingtool.target-version = "py39".I believe a better implementation is to not capture the exception at all and error out, this way no unintended modifications to the TOML file are performed.
Another option is to continue capturing the exception but error out using
exit(1).What do you think?