feat: add support for setting array element #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the 'set' command lacks the access to an array element by index. This patch adds this feature. Example: `toml set --toml-path pyproject.toml tool.poetry.authors[0] "Marc Rijken <[email protected]>"`
mrijken
reviewed
Jun 22, 2024
toml_cli/__init__.py
Outdated
| if match: | ||
| table = match.group("table") | ||
| index = int(match.group("index")) | ||
| toml_part[table][index] = value |
There was a problem hiding this comment.
Could you a descriptive message to the user when the table or index does not exists and exit with exit code 1
Whenever accessing a non-existent array, the 'set' command should error out and print a message instead of a python exception with traceback information.
Currently the 'set' command fails to add an array element when the index does not already exists, it fires an'IndexError' exception. The underlying 'tomlkit' library offers a handy 'tomlkit.items.Array.insert()' method which inserts a value before an index. This is the proposed behavior: $ cat config.toml cities = ["Rotterdam"] $ toml set 'cities[1]' = 'Amsterdam' && cat config.toml cities = ["Rotterdam", "Amsterdam"] $ toml set 'cities[999]' = 'Eindhoven' && cat config.toml cities = ["Rotterdam", "Amsterdam", "Eindhoven"]
|
I've added both features:
|
Co-authored-by: Marc Rijken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the 'set' command lacks the access to an array element by index. This patch adds this feature.
Example:
toml set --toml-path pyproject.toml tool.poetry.authors[0] "Marc Rijken <[email protected]>"