Skip to content

Commit

Permalink
Popin ad extension document updated. (ampproject#7674)
Browse files Browse the repository at this point in the history
* Add popin ad extension.

* register popin.

* Add resizeable attribute.

* Remove resizable.

* Implemented the render-start and no-content APIs.

* Fixed lint.

* Remove quatation.

* Use [email protected]

* Rebase old commit .

* Fixed document because tag was not closed.

* I replaced the removed double quotes.

* Add double quotes.
  • Loading branch information
popinuser authored and mrjoro committed Apr 28, 2017
1 parent 75c3500 commit 7bf2199
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions ads/popin.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ limitations under the License.
```html
<amp-ad
type="popin"
width=300
height=568
width="300"
height="568"
layout=responsive
heights="(min-width:1907px) 39%, (min-width:1200px) 46%, (min-width:780px) 64%, (min-width:480px) 98%, (min-width:460px) 167%, 196%"
data-mediaid="popin_amp"
data-mediaid="popin_amp">
</amp-ad>
```

Expand Down

0 comments on commit 7bf2199

Please sign in to comment.