Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match subdirectories starting with . in {dot: false} mode #226

Closed
sgtlambda opened this issue Sep 7, 2019 · 2 comments
Closed

Match subdirectories starting with . in {dot: false} mode #226

sgtlambda opened this issue Sep 7, 2019 · 2 comments
Assignees
Milestone

Comments

@sgtlambda
Copy link

sgtlambda commented Sep 7, 2019

Environment

  • OS Version: macOS 10.14.6
  • Node.js Version: 11.12.0

Actual behavior

When the dot option is disabled (default behavior), foo/{.,}**/{.,}* matches foo/bar/.file but not foo/.bar/file

Expected behavior

foo/{.,}**/{.,}* should still match foo/.bar/file even if the dot option is disabled because the pattern explicitly includes subdirectories starting with ..

Steps to reproduce

Create demo files, run sample code

Code sample

Directory structure:

.
└── foo
    ├── .bar
    │   └── file
    └── bar
        └── .file
require('globby')([
    'foo/{.,}**/{.,}*'
]).then(console.log);
@mrmlnc mrmlnc self-assigned this Sep 21, 2019
@mrmlnc
Copy link
Owner

mrmlnc commented Sep 21, 2019

You're right. This is a bug inside deep filter.

@mrmlnc
Copy link
Owner

mrmlnc commented Sep 21, 2019

Will be fixed with [email protected] (#231).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants