Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-226: match dot directories by patterns #228

Merged
merged 1 commit into from
Sep 21, 2019

Conversation

mrmlnc
Copy link
Owner

@mrmlnc mrmlnc commented Sep 21, 2019

What is the purpose of this pull request?

This is a fix for #226.

What changes did you make? (Give an overview)

We do not need to try to skip dot directories without applying patterns. The pattern may explicitly includes subdirectories starting with ..

@mrmlnc
Copy link
Owner Author

mrmlnc commented Sep 21, 2019

/azp run benchmark.regression

@mrmlnc
Copy link
Owner Author

mrmlnc commented Sep 21, 2019

/azp run benchmark

@mrmlnc mrmlnc force-pushed the ISSUE-226_drop_broken_optimization_for_dot branch 2 times, most recently from cff5d44 to ffaad38 Compare September 21, 2019 10:23
@mrmlnc mrmlnc changed the title ISSUE-226: match dot directories with by patterns ISSUE-226: match dot directories by patterns Sep 21, 2019
We do not need to try to skip dot directories without applying patterns. The pattern may explicitly includes subdirectories starting with `.`.
@mrmlnc mrmlnc force-pushed the ISSUE-226_drop_broken_optimization_for_dot branch from ffaad38 to f971fb4 Compare September 21, 2019 18:26
@mrmlnc mrmlnc merged commit 6253406 into master Sep 21, 2019
@mrmlnc mrmlnc deleted the ISSUE-226_drop_broken_optimization_for_dot branch September 21, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant