Make async available in named export #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josh-hemphill, thanks for the contributing 🎉 Will be shipped with I also create #397 to simplify the life of developers. |
1 task
renovate bot
referenced
this pull request
in redwoodjs/redwood
Aug 2, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fast-glob](https://togithub.com/mrmlnc/fast-glob) | [`3.2.12` -> `3.3.1`](https://renovatebot.com/diffs/npm/fast-glob/3.2.12/3.3.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mrmlnc/fast-glob (fast-glob)</summary> ### [`v3.3.1`](https://togithub.com/mrmlnc/fast-glob/releases/tag/3.3.1) [Compare Source](https://togithub.com/mrmlnc/fast-glob/compare/3.3.0...3.3.1) > **Full Changelog**: mrmlnc/fast-glob@3.3.0...3.3.1 This release fixes a regression for cases where the `ignore` option is used with a string ([#​403](https://togithub.com/mrmlnc/fast-glob/issues/403), [#​404](https://togithub.com/mrmlnc/fast-glob/issues/404)). The public interface of this package does not support a string as the value for the [`ignore` option](https://togithub.com/mrmlnc/fast-glob#ignore) since 2018 year ([release](https://togithub.com/mrmlnc/fast-glob/releases/tag/2.0.0)). So, in the next major release, we will reintroduce method implementations that do not involve strings in the `ignore` option. ### [`v3.3.0`](https://togithub.com/mrmlnc/fast-glob/releases/tag/3.3.0) [Compare Source](https://togithub.com/mrmlnc/fast-glob/compare/3.2.12...3.3.0) > **Full Changelog**: mrmlnc/fast-glob@3.2.12...3.3.0 #### 🚀 Improvements **Method aliases** New methods (`glob`, `globSync`, `globStream`) have been added in addition to the current methods (default import, `sync`, `stream`), which eliminate the need to rename the method when importing. In addition, an `async` alias has been added for the default import, which makes it possible to use this packet with ESM. **Method to convert paths to globs** A new method (`convertPathToPattern`) has been added in this release to convert a path to a pattern. The primary goal is to enable users to avoid processing Windows paths in each location where this package is used by utilities from third-party packages. See more details in the [pull request](https://togithub.com/mrmlnc/fast-glob/pull/392). #### 🐛 Bug fixes - In the past, we mishandled patterns that contained slashes when the `baseNameMatch` option was enabled, which went against the documented behavior. ([#​312](https://togithub.com/mrmlnc/fast-glob/issues/312)) - Several problems with matching patterns that contain brace expansion have been resolved. The primary issue solved is when the pattern has duplicate slashes after it is expanded ([#​394](https://togithub.com/mrmlnc/fast-glob/issues/394)), or the `micromatch` package does not correctly generate a regular expression ([#​365](https://togithub.com/mrmlnc/fast-glob/issues/365)). - All negative patterns will now have the `dot` option enabled when matching paths. Previously, the `!**/*` patterns did not exclude hidden files (start with a dot). ([#​343](https://togithub.com/mrmlnc/fast-glob/issues/343)) - The issue that led to duplicates in the results when overlapping or duplicate patterns were present among the patterns has been fixed. At the moment, we are only talking about leading dot. Other cases are not included. For example, running with the patterns `['./file.md', 'file.md', '*']` will now only include `file.md` once in the results. ([#​190](https://togithub.com/mrmlnc/fast-glob/issues/190)) #### 📖 Documentation A [clarifying note](https://togithub.com/mrmlnc/fast-glob/blob/master/README.md#concurrency) has been added for the `concurrency` option, which provides more detailed information about the Thread Pool utilization. #### ⚙️ Infrastructure - The benchmark in CI is now running on Node.js 20. - The benchmark now uses the public package [bencho](https://togithub.com/mrmlnc/bencho) instead of an in-house implementation. You may want to try this solution for your packages and provide feedback. #### 🥇 New Contributors - [@​josh-hemphill](https://togithub.com/josh-hemphill) made their first contribution in [https://github.com/mrmlnc/fast-glob/pull/383](https://togithub.com/mrmlnc/fast-glob/pull/383) - [@​mairaw](https://togithub.com/mairaw) made their first contribution in [https://github.com/mrmlnc/fast-glob/pull/401](https://togithub.com/mrmlnc/fast-glob/pull/401) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
This was referenced Sep 9, 2024
](https://renovatebot.com){kind=link}
This was referenced Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
For people using ESM projects, assigning to
export = FastGlobmakes default import impossible without TSC interop interceding for it.Ideally, the export signature should change, but that would be a breaking change.
What changes did you make? (Give an overview)
So for now, and to make the export signature more consistent anyway, I'm proposing just adding the async implementation to the named exports, which happens to also be best-practice for ESM.