Add retries to circleci CRUD resources #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgermain
reviewed
May 7, 2020
Comment on lines
+185
to
+196
| exists, err := providerClient.EnvVarExists(organization, projectName, envName) | ||
| if err != nil { | ||
| return wrap(err) | ||
| } | ||
|
|
||
| if exists { | ||
| return fmt.Errorf("environment variable '%s' already exists for project '%s'", envName, projectName) | ||
| } | ||
| if exists { | ||
| return wrap(fmt.Errorf("environment variable '%s' already exists for project '%s'", envName, projectName)) | ||
| } | ||
|
|
||
| if _, err := providerClient.AddEnvVar(organization, projectName, envName, envValue); err != nil { | ||
| return err | ||
| } | ||
| if _, err := providerClient.AddEnvVar(organization, projectName, envName, envValue); err != nil { | ||
| return wrap(err) | ||
| } |
There was a problem hiding this comment.
Should we split the retry here and use a different, one for the call to EnvVarExists() and another retry for AddEnvVar() ?
If the first one succeed (and return false) but the second one fail due to network issue (aka a retryable error), should we do the first request again too?
I'm not sure if it's overkill to do 2 different retries and what we gain from doing only one.
What do you think?
|
@ajlake would you mind rebasing on master? If you are going to split the two retries please also do that so we can merge this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI occasionally gives back transient http 500 errors, resulting in terraform plans/applies failing. This only gets worse as the number of CircleCI variables in a terraform workspace grows. This change takes advantage of terraform's native retry functionality to wrap CRUD operations in an attempt to mitigate the issue.