-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty vars in safe mode #133
Comments
Hmmmm, Yeah if dotenv-safe supports that we should probably too, but I think it should be configurable just like dotenv. Any chance you wanna make a go at it? |
Sure! I just submitted PR #134. I've added an option |
@mrsteele Do you think you'll have time to review? |
Any update on this ? |
Is this repo dead? This feature is actually useful |
Anyone willing to resolve the conflicts? |
If @mkrause is not available, I am willing to make a new PR with the old one's content. |
I can fix the conflicts. Over the weekend maybe. |
Updated the PR |
* (#133) Add option allowEmptyValues. * (#133) Add README example for allowEmptyValues. * (allowEmptyValues) Update PR to be compatible with latest master. Co-authored-by: Matt Steele <[email protected]>
In #14, empty variables were allowed, but only in non-safe mode. But even in safe mode we'd often like to use an empty string as a possible value. Can we make a distinction between
.env
variables that are not specified as opposed to variables that are just empty?The lack of
BAR
should result in an error,FOO
should not.Also worth noting that dotenv-safe allows empty values, configurable through an "allowEmptyValues" option.
The text was updated successfully, but these errors were encountered: