Fix validation of Nonce length

mrsuciu · Jun 14, 2024 · b5db0fb · b5db0fb
1 parent b6ce654
commit b5db0fb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/Stack/Opc.Ua.Core/Security/Certificates/Nonce.cs b/Stack/Opc.Ua.Core/Security/Certificates/Nonce.cs
@@ -328,11 +328,6 @@ public static uint GetNonceLength(string securityPolicyUri)
         {
             switch (securityPolicyUri)
             {
-                case SecurityPolicies.Basic128Rsa15:
-                {
-                    return 16;
-                }
-
                 case SecurityPolicies.Basic256:
                 case SecurityPolicies.Basic256Sha256:
                 case SecurityPolicies.Aes128_Sha256_RsaOaep:

diff --git a/Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryChannel.Asymmetric.cs b/Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryChannel.Asymmetric.cs
@@ -234,7 +234,7 @@ protected bool ValidateNonce(X509Certificate2 certificate, byte[] nonce)
             }
 
             // check the length.
-            if (nonce == null || nonce.Length < Nonce.GetNonceLength(SecurityPolicyUri))
+            if (nonce == null || nonce.Length != Nonce.GetNonceLength(SecurityPolicyUri))
             {
                 return false;
             }