Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make everything multilanguage - All changes at once. #236

Open
wants to merge 126 commits into
base: master
Choose a base branch
from
Open

Make everything multilanguage - All changes at once. #236

wants to merge 126 commits into from

Conversation

meiremans
Copy link
Contributor

@meiremans meiremans commented Aug 26, 2021 •
edited
Loading

Maybe overloading you with PR's is not nice.

So this are all the changes bundled.

allows for payment with wiretransfer or pay on delivery
Added Romanian translation.
save the currency used in the order.
bumped stripe, as the current version didn't seem to work
bumped docker node image, as 8 is deprecated
added a fuzzy search with 1 edit as range for the search.
added missing I18N
make product data multilanguage
make menu multilanguage
productfeed will be made for every language
revised hook system & add product onCreate hook

@meiremans
allow for RON currency
40aa395
@meiremans
added romanian as language option.
b861a48 
Translation of everything will follow next week
@meiremans
added romanian as language option.
5a880a2 
Translation of everything will follow next week
@meiremans
themes are loaded from views not public
9ba41d8
@meiremans
Add wiretransfer and payment on delivery as payment options
d725bd1
@meiremans
added account number to the wiretransfer config
ed9b524
@meiremans
make search fuzzy by 1 edit, for convenience for the end user
78fad9c
@meiremans
make search fuzzy by 1 edit, for convenience for the end user
647ef40 
Signed-off-by: nick <[email protected]>
@meiremans
Merge pull request #1 from meiremans/EXTRA_CUIRRENCY_RON
47d6948 
allow for RON currency
@meiremans
Merge pull request #2 from meiremans/FUZZY_SEARCH
424385a 
Fuzzy search
@meiremans
Merge remote-tracking branch 'origin/FUZZY_SEARCH' into FUZZY_SEARCH
4a41710
@meiremans
save order currency in DB.
5a1c28a
@meiremans
Merge pull request #3 from meiremans/SAVE_ORDER_CURRENCY
17385e7 
save order currency in DB.
@meiremans
there are shipping costs when using wiretransfer or pay on delivery
8b9a4cd
@meiremans
add RO translations
1e05992
@meiremans
add RO translations
5b5bbc2 
Signed-off-by: nick <[email protected]>
@meiremans
Merge pull request #5 from meiremans/EXTRA_LANGUAGE_RO
74e1c22 
Extra language ro
@meiremans
Merge branch 'master' into PAYMENT_PAY_ON_DELIVERY
9f43ad6
@meiremans
Merge pull request #4 from meiremans/PAYMENT_PAY_ON_DELIVERY
5a6a6ba 
there are shipping costs when using wiretransfer or pay on delivery
@meiremans
Merge pull request #6 from meiremans/THEMES_LOADED_FROM_VIEWS
e69b165 
themes are loaded from views not public
@meiremans
Merge pull request #7 from meiremans/FUZZY_SEARCH
fd77d85 
Fuzzy search
@meiremans
Merge remote-tracking branch 'origin/EXTRA_LANGUAGE_RO' into EXTRA_LA…
a433b27 
…NGUAGE_RO
@meiremans
current version didn't work for me, bumping it solved the issue
ad095bd
@meiremans
Merge pull request #8 from meiremans/BUMP_STRIPE
667069d 
current version didn't work for me, bumping it solved the issue
@meiremans
running on a deprecated LTS is not recomended?
f3ddbee 
bumped it to 14. seems to work fine.
@meiremans
Merge pull request #9 from meiremans/BUMP_DOCKER_NODE
9a8c25c 
running on a deprecated LTS is not recomended?
@meiremans
Merge pull request #10 from meiremans/EXTRA_LANGUAGE_RO
4e6913d 
Extra language ro
@meiremans
fixed a lot of missing I18N fixed strings
c5aa55b 
Signed-off-by: nick <[email protected]>
@meiremans
Merge pull request #11 from meiremans/I18N_EVERYWHERE
a42291b 
fixed a lot of missing I18N fixed strings
@meiremans
fixed a lot of missing I18N fixed strings
f19270e 
Signed-off-by: nick <[email protected]>
@meiremans
v++
cb54c0c 
Signed-off-by: Nick <[email protected]>
@meiremans
add testdata to dockerfile
2cb9f0d 
Signed-off-by: Nick <[email protected]>
@meiremans
Merge pull request #34 from meiremans/PREPARE_NEXT_VERSION
e096c18 
Prepare next version
@meiremans
v++
770ca4d 
Signed-off-by: Nick <[email protected]>
@meiremans
Merge pull request #35 from meiremans/PREPARE_NEXT_VERSION
4485b89 
v++
@meiremans
remove build from dockerfile
19945e1
@meiremans
Merge pull request #36 from meiremans/PREPARE_NEXT_VERSION
53a3c06 
remove build from dockerfile
@meiremans
add production docker in compose
398b0f7 
remove dev from default compose up command
@meiremans
Merge pull request #37 from meiremans/SEPARATE_DEV_AND_PROD_DOKER
10b3019 
add production docker in compose
@meiremans
no need to install extras, as we are not using alpine anymore
93fcb6e
@meiremans
Merge pull request #38 from meiremans/SEPARATE_DEV_AND_PROD_DOKER
0cea7d9 
no need to install extras, as we are not using alpine anymore
@meiremans
fix # in selector productEdit when selecting default language
adc15df 
put back productId in hidden field (removed in merge)
@meiremans
Merge pull request #39 from meiremans/SEPARATE_DEV_AND_PROD_DOKER
012913a 
fix product edit multilang
@meiremans
will take thumbnail if one was generated in the system, otherwise it …
f01da1a 
…will take the full picture
@meiremans
Merge pull request #40 from meiremans/FIX_THUMBNAILS
b4cdd71 
will take thumbnail if one was generated in the system, otherwise it …
@meiremans
remove dimensions if one dimension is not filled in
44a0fb3
@meiremans
Merge pull request #41 from meiremans/HIDE_DIMENSIONS_IF_EMPTY
31a4329 
remove dimensions if one dimension is not filled in
@meiremans
new version minified JS/css
8718c37
@meiremans
Merge pull request #42 from meiremans/NEW_MENU_ADD_LANGUAGE
3f36a6c 
new version minified JS/css
@meiremans
add deploy to dockerfile to generate min js/css on rebuild
e2b538a
@meiremans
Merge pull request #43 from meiremans/NEW_MENU_ADD_LANGUAGE
a036c30 
add deploy to dockerfile to generate min js/css on rebuild
@meiremans
actually wait for promises to resolve
664001e
@meiremans
Merge pull request #44 from meiremans/NEW_MENU_ADD_LANGUAGE
a516eb0 
actually wait for promises to resolve
@meiremans
check language on returned menu
52284e7
@meiremans
Merge pull request #45 from meiremans/NEW_MENU_ADD_LANGUAGE
6c2c0d9 
check language on returned menu
@meiremans
V++
a413423
@meiremans
Merge pull request #46 from meiremans/NEW_MENU_ADD_LANGUAGE
41fbc43 
V++
@meiremans
Copy link
Contributor Author

Hello.

This became a bunch of commits.
As for this version (V1.2.3 on my branch), I deployed a demo: https://expresscart.ab-it.io/
(same login as your demo).

Could you have a look, see if these are changes you would like to incorporate in expressCart?
If you think these changes are out of scope, I'll close the PR.

If you have some remarks, I'll be glad to solve them.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meiremans @ioannis-matzaris