Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new "hold" command to for hold gestures #50

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

michaelkollmann
Copy link

Hi!

I have added a new command for both iOS and Android called "Hold".

This command gets triggered if the user presses the control and holds it down for 800 milliseconds.
It does not require the user to raise his finger. That's the main difference between this and the Long Tap command.

I have already updated the nuspec-version to 1.7.0 and the README.md file as well.

In theory, you should be able to publish the new NuGet package version of this one right away.
I'd greatly appreciate having this as a NuGet package so that I can easily integrate it into the project I am working on at the moment.

Cheers
Michael

@mrxten
Copy link
Owner

mrxten commented Jul 17, 2020

Hi, thank you. Hold isn't need since now just "long tap" works incorrect :)
If you have a free time - please just fix long command instead adding hold.

@michaelkollmann
Copy link
Author

So just to confirm, the "long tap" command is supposed to work like the "hold" command does work now in my implementation?

Not sure about changing the behavior of the "long tap" though.
Somebody might use it like it is and be very confused on why we change the behavior of an existing command.
That's why I have added a new command instead of changing the old one.

But I can also update the "long tap" command to work just the same as my "hold" command does work now.

What do you prefer?

@mrxten
Copy link
Owner

mrxten commented Jul 25, 2020

No, long tap now works incorrectly 100%. It was correct some time ago.

@michaelkollmann
Copy link
Author

I have updated the samples so that every command has its own button to try.
Also, I tested it on both iOS and Android.

Both seem to be working as expected for me (now that I have found a bug which caused the Hold command to not work properly)

Can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants