Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up newCordovaViewWithFrame in order to extract initializ… #1

Merged
merged 1 commit into from
Jan 6, 2021
Merged

chore: clean up newCordovaViewWithFrame in order to extract initializ… #1

merged 1 commit into from
Jan 6, 2021

Conversation

msmtamburro
Copy link
Owner

…ation with configuration

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

dpogue
dpogue approved these changes Jan 6, 2021
View reviewed changes
Copy link

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@msmtamburro msmtamburro merged commit 842bc67 into issue_900_websiteDataStore Jan 6, 2021
@msmtamburro msmtamburro deleted the issue_900_refactor_newCordovaViewWithFrame branch January 6, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpogue dpogue dpogue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msmtamburro @dpogue