Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/ as first symbol #11

Open
freeseacher opened this issue May 28, 2010 · 5 comments
Open

/ as first symbol #11

freeseacher opened this issue May 28, 2010 · 5 comments
Labels
pending Not looking at it yet

Comments

@freeseacher
Copy link

Hello!

it will be great if slash in the beginning of filename will be ignored and don't raises TftpException
i try to get file from tftpy my device got command get -u tftp://$ip:$port/filename and sends /filename as a file to get. unfortunately i can't control that behavior
@msoulier
Copy link
Owner

Hmm. Perhaps not by default, but with some option to the server to be more tolerant. Don't forget that / is only special on Unix.

@msoulier
Copy link
Owner

msoulier commented Jun 5, 2010

I'm assuming that this is in the sample client? It can't be in the api or you'd just fix it yourself in what you pass in.

@freeseacher
Copy link
Author

no, that is not sample client. that is client on Linksys spa2102 and Audiocodes mp-202.

@ghost ghost assigned msoulier Aug 26, 2011
@msoulier
Copy link
Owner

Taking for 0.7.

UnwashedMeme pushed a commit to UnwashedMeme/tftpy that referenced this issue Nov 1, 2013
Fixing msoulier#11: server accept leading '/' in uploads
3481af8 
Some devices, when uploading, always have a leading '/' that led to the
joined path being outside the server's root directory causing "bad file
path" TftpExceptions. The only way to work around this is if the remote
client knew the full path on this server (unnecessarily tight coupling).

This patch removes the leading '/' so that all paths are relative to the
server's root directory.

To help preserve backwards compatibility there is an exception to the
above rule that if the client's specified path starts with the server's
root directory then accept it.
@freeseacher
Copy link
Author

probably that issue should be closed

@msoulier msoulier removed this from the 0.7 Release milestone Mar 22, 2019
@msoulier msoulier added the pending Not looking at it yet label Mar 22, 2019
@msoulier msoulier removed their assignment Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending Not looking at it yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msoulier @freeseacher